Tweak code to avoid NVHPC 21.7 ICE#1385
Merged
alexsavulescu merged 1 commit intomasterfrom Jul 28, 2021
Merged
Conversation
Collaborator
Author
|
Replaced a code change with a more targeted CMake change. Should be good to go. |
olupton
force-pushed
the
olupton/nvhpc-21.7
branch
from
6da3a0b to
8098b21
Compare
olupton
force-pushed
the
olupton/nvhpc-21.7
branch
from
8098b21 to
b517297
Compare
pramodk
approved these changes
Jul 27, 2021
| AND "${CMAKE_C_COMPILER_VERSION}" VERSION_GREATER_EQUAL 21.7) | ||
| set_source_files_properties(${PROJECT_SOURCE_DIR}/src/mesch/znorm.c PROPERTIES COMPILE_OPTIONS | ||
| -Mnovect) | ||
| endif() |
Member
There was a problem hiding this comment.
Just for reference, see #901 : here intel compiled was causing deadlock with AVX-512.
Just an idea : as this issue is with the loop vectoriser, if writing loop in different form would avoid compiler internal error then that could be an option. Then we won't need to maintain cmake patches around.
alexsavulescu
approved these changes
Jul 27, 2021
Member
|
Just as a side note, I also found out about |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change then NEURON fails to compile with the latest NVIDIA HPC compiler release, 21.7. There is an internal compiler error in
znorm.c, see https://forums.developer.nvidia.com/t/nvc-21-7-regression-internal-compiler-error-can-only-coerce-indirect-args/184847 for more information.This change disables vectorisation optimisations for that file to sidestep the error, as suggested on the NVIDIA forums.