Skip to content

Add test coverage for async contexts#1164

Merged
JckXia merged 1 commit intonodejs:mainfrom
JckXia:add-test-coverage-for-async-cxt
Apr 29, 2022
Merged

Add test coverage for async contexts#1164
JckXia merged 1 commit intonodejs:mainfrom
JckXia:add-test-coverage-for-async-cxt

Conversation

@JckXia
Copy link
Copy Markdown
Member

@JckXia JckXia commented Apr 16, 2022

Add unit test for async context. This will close this github issue: #1038

@JckXia JckXia force-pushed the add-test-coverage-for-async-cxt branch from 6cbb513 to 87dcf57 Compare April 20, 2022 21:56
Copy link
Copy Markdown
Contributor

@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It appears to test AsyncContext() constructor with no resource object as well as the context.Env() method, which were the two remaining methods in #1038

@JckXia
Copy link
Copy Markdown
Member Author

JckXia commented Apr 29, 2022

Thanks for the review @KevinEady. Yep It covers the remaining methods for AsyncContext

@JckXia JckXia merged commit f32db91 into nodejs:main Apr 29, 2022
@JckXia
Copy link
Copy Markdown
Member Author

JckXia commented Apr 29, 2022

Landed as f32db91

@JckXia JckXia deleted the add-test-coverage-for-async-cxt branch April 29, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants