This repository was archived by the owner on Apr 22, 2023. It is now read-only.
net: ensure Socket reported address is current#25753
Closed
rmg wants to merge 1 commit intonodejs:masterfrom
rmg:node-0.12-no-reuse-sockname
Closed
net: ensure Socket reported address is current#25753rmg wants to merge 1 commit intonodejs:masterfrom rmg:node-0.12-no-reuse-sockname
rmg wants to merge 1 commit intonodejs:masterfrom
rmg:node-0.12-no-reuse-sockname
Conversation
Any time the connection state or the underlying handle itself changes, the socket's name (aka, local address) can change. To deal with this we need to reset the cached sockname any time we set or unset the internal handle or an existing handle establishes a connection.
Member
|
@rmg .. this should be closed here. I believe the PR landed over on the nodejs/node side. Can reopen this if necessary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any time the connection state or the underlying handle itself changes,
the socket's name (aka, local address) can change.
To deal with this we need to reset the cached sockname any time we
set or unset the internal handle or an existing handle establishes a
connection.
Fixes #25621
Same PR on iojs: nodejs/node#2095