Skip to content

test: fix failure in test-icu-data-dir.js #13987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tniessen wants to merge 3 commits into from
Closed

test: fix failure in test-icu-data-dir.js #13987

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8573ce8
src: revert 13940
tniessen Jun 29, 2017
1f83952
fix CI on Windows
tniessen Jun 29, 2017
08afcaa
fix
tniessen Jun 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4372,7 +4372,7 @@ void Init(int* argc,
if (!i18n::InitializeICUDirectory(icu_data_dir)) {
fprintf(stderr,
"%s: could not initialize ICU "
"(check NODE_ICU_DATA or --icu-data-dir parameters)\n",
"(check NODE_ICU_DATA or --icu-data-dir parameters)",
argv[0]);
exit(9);
}
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-icu-data-dir.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const { spawnSync } = require('child_process');

const expected =
'could not initialize ICU ' +
'(check NODE_ICU_DATA or --icu-data-dir parameters)\n';
'(check NODE_ICU_DATA or --icu-data-dir parameters)';

{
const child = spawnSync(process.execPath, ['--icu-data-dir=/', '-e', '0']);
Expand Down