Skip to content

Prototype bleeding in events.js #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martinheidegger wants to merge 2 commits into from
Closed

Prototype bleeding in events.js #2044

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a38f9cf
Added new test for prototype bleeding
martinheidegger Jun 23, 2015
21706a7
Correcting style to be lint-conform.
martinheidegger Jun 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions test/parallel/test-event-emitter-prototype-bleeding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
'use strict';
var util = require('util');
var EventEmitter = require('events').EventEmitter;

var TestClass = function () {};
Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Jun 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not function TestClass () {}?

TestClass.prototype = new EventEmitter;

function listener_n1() {
// This one is okay to be called!
Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Jun 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function must be called, right? Why not assign some value to a variable here and check if the value is set in process.exit?

}
function listener_n2() {
throw new Error("This one should not be called!")
Copy link
Copy Markdown
Contributor

@thefourtheye thefourtheye Jun 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the number of spaces required is 2. Is make lint happy about this?

}

var ok = new TestClass();
var broken = new TestClass();
broken.on('end', listener_n2);
ok.on('end', listener_n1);
ok.emit('end');