Skip to content

test: fix test-repl-require-after-write #27088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 4 commits into from
Closed

test: fix test-repl-require-after-write #27088

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
435592c
test: fix test-repl-require-after-write
targos Apr 4, 2019
29d8dd3
Update test-repl-require-after-write.js
targos Apr 4, 2019
999b260
path.join
targos Apr 5, 2019
2d5d3e3
Update test-repl-require-after-write.js
targos Apr 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions test/parallel/test-repl-require-after-write.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,21 @@
'use strict';

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const assert = require('assert');

const spawn = require('child_process').spawn;

tmpdir.refresh();

const requirePath = tmpdir.path + '/non-existent.json';
Copy link
Copy Markdown
Member

@lpinca lpinca Apr 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: path.join()?


// Use -i to force node into interactive mode, despite stdout not being a TTY
const child = spawn(process.execPath, ['-i']);

let out = '';
const input = "try { require('./non-existent.json'); } catch {} " +
"require('fs').writeFileSync('./non-existent.json', '1');" +
"require('./non-existent.json');";
const input = `try { require('${requirePath}'); } catch {} ` +
`require('fs').writeFileSync('${requirePath}', '1');` +
`require('${requirePath}');`;

child.stderr.on('data', common.mustNotCall());

Expand Down