Skip to content

lib: rename lib/internal/readline.js#28753

Closed
cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig:rl-refactor
Closed

lib: rename lib/internal/readline.js#28753
cjihrig wants to merge 1 commit intonodejs:masterfrom
cjihrig:rl-refactor

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jul 18, 2019 •
edited
Loading

This commit moves lib/internal/readline.js to lib/internal/readline/utils.js. This is in preparation of adding a readline.promises implementation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@trivikr trivikr trivikr approved these changes

+2 more reviewers

@antsmartian antsmartian antsmartian approved these changes

@Leko Leko Leko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. readline Issues and PRs related to the built-in readline module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cjihrig @nodejs-github-bot @Trott @antsmartian @Leko @lpinca @targos @trivikr