Skip to content

stream: fix handling generators in Readable.from #32844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vadzim wants to merge 11 commits into from
+229 −1
Closed

stream: fix handling generators in Readable.from #32844

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2fa5848
stream: close iterator in Readable.from
vadzim Apr 14, 2020
980a7c8
fixup: explicit `yielded` event in closeStreamWhileNextIsPending
vadzim Apr 15, 2020
b772927
fixup: test fot iterator closing after null has been yielded
vadzim Apr 15, 2020
57bb126
fixup: escape unhandled rejected promise
vadzim Apr 15, 2020
8a2974f
fixup: test for closing iterator on yielded null
vadzim Apr 15, 2020
8528ad4
fixup: fix variable name
vadzim Apr 15, 2020
e821b98
fixup: run callback with process.nextTick
vadzim Apr 15, 2020
e9becca
remove unnesessary closure
vadzim Apr 15, 2020
509be2c
fixup: do not doublecheck needToClose flag
vadzim Apr 15, 2020
7aac752
fixup: make _destroy not async
vadzim Apr 16, 2020
bffbf58
fixup: trigger build
vadzim Apr 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/streams/from.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function from(Readable, iterable, opts) {
} catch (e) {
error = error || e;
} finally {
cb(error);
process.nextTick(() => cb(error));
Comment thread
ronag marked this conversation as resolved.
Outdated
}
};
Comment thread
vadzim marked this conversation as resolved.

Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-readable-from-iterator-closing.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ async function closeStreamWhileNextIsPending() {

async function closeAfterNullYielded() {
const finallyMustCall = mustCall();
const bodyMustCall = mustCall(3);
const dataMustCall = mustCall(3);

function* infiniteGenerate() {
try {
Expand All @@ -182,7 +182,7 @@ async function closeAfterNullYielded() {
const stream = Readable.from(infiniteGenerate());

stream.on('data', (chunk) => {
bodyMustCall();
dataMustCall();
strictEqual(chunk, 'a');
});
}
Expand Down