Skip to content

src: add cjs_module_lexer_version and base64_version#45629

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
MrJithil:addCjsModuleLexerVersion
May 14, 2023
Merged

src: add cjs_module_lexer_version and base64_version#45629
nodejs-github-bot merged 1 commit intonodejs:mainfrom
MrJithil:addCjsModuleLexerVersion

Conversation

@MrJithil
Copy link
Member

@MrJithil MrJithil commented Nov 26, 2022 •
edited
Loading

Ref: #45260

Added version info of cjs_module_lexer and base64_version

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Nov 26, 2022
@MrJithil MrJithil force-pushed the addCjsModuleLexerVersion branch from 31cef86 to 1791f9b Compare November 26, 2022 04:10
@MrJithil MrJithil changed the title build: add cjs_module_lexer_version build: add cjs_module_lexer_version and base64_version Nov 26, 2022
@MrJithil MrJithil force-pushed the addCjsModuleLexerVersion branch 6 times, most recently from f5d3e71 to 65d9864 Compare November 26, 2022 05:00
@MrJithil MrJithil changed the title build: add cjs_module_lexer_version and base64_version src: add cjs_module_lexer_version and base64_version Nov 26, 2022
@MrJithil MrJithil force-pushed the addCjsModuleLexerVersion branch from 65d9864 to 67ffed7 Compare November 26, 2022 05:37
@MrJithil MrJithil closed this Nov 27, 2022
@MrJithil MrJithil reopened this Nov 27, 2022
@MrJithil MrJithil mentioned this pull request Nov 27, 2022
Closed
6 tasks
@MrJithil
Copy link
Member Author

MrJithil commented Nov 27, 2022

Can we add process label if I am not wrong.

jasnell
jasnell reviewed Nov 27, 2022
View reviewed changes
@MrJithil MrJithil force-pushed the addCjsModuleLexerVersion branch 2 times, most recently from 3fff7bc to 03da04e Compare November 29, 2022 09:05
@MrJithil MrJithil closed this Nov 29, 2022
@MrJithil MrJithil reopened this Nov 29, 2022
@MrJithil MrJithil closed this Dec 1, 2022
@MrJithil MrJithil reopened this Dec 1, 2022
@MrJithil MrJithil closed this Dec 2, 2022
@MrJithil MrJithil reopened this Dec 2, 2022
@MrJithil MrJithil force-pushed the addCjsModuleLexerVersion branch from 03da04e to 3b1d99c Compare December 12, 2022 09:58
@MrJithil
Copy link
Member Author

MrJithil commented Dec 12, 2022

Resolved conflicts

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
aduh95
aduh95 reviewed May 13, 2023
View reviewed changes
@aduh95 aduh95 dismissed their stale review May 13, 2023 11:47

My requested changes have been addressed, my remaining comments are non-blocking

@github-actions github-actions bot mentioned this pull request May 14, 2023
Open
14 tasks
@MrJithil
src: add cjs_module_lexer_version base64_version
8af37e7 
src: add cjs_module_lexer_version base64_version
@MrJithil MrJithil force-pushed the addCjsModuleLexerVersion branch from e5ff1cd to 8af37e7 Compare May 14, 2023 04:41
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 14, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 14, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/51784/

@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 14, 2023
@nodejs-github-bot nodejs-github-bot merged commit abb1c45 into nodejs:main May 14, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 14, 2023

Landed in abb1c45

targos pushed a commit that referenced this pull request May 14, 2023
@MrJithil @targos
src: add cjs_module_lexer_version base64_version
dd8ed39 
src: add cjs_module_lexer_version base64_version
PR-URL: #45629
Refs: #45260
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actions github-actions bot mentioned this pull request May 15, 2023
Open
17 tasks
@targos targos added the semver-minor PRs that contain new features and should be released in the next minor version. label May 15, 2023
@targos targos mentioned this pull request May 15, 2023
Closed
targos pushed a commit that referenced this pull request May 15, 2023
@MrJithil @targos
src: add cjs_module_lexer_version base64_version
1aec718 
src: add cjs_module_lexer_version base64_version
PR-URL: #45629
Refs: #45260
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request May 15, 2023
Merged
@amul69906995 amul69906995 mentioned this pull request May 15, 2023
Closed
This was referenced May 16, 2023
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 10, 2023
@MrJithil @targos
src: add cjs_module_lexer_version base64_version
cc7bf1f 
src: add cjs_module_lexer_version base64_version
PR-URL: #45629
Refs: #45260
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@JungMinu JungMinu JungMinu approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. semver-minor PRs that contain new features and should be released in the next minor version. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@MrJithil @nodejs-github-bot @aduh95 @debadree25 @jasnell @JungMinu @RaisinTen @panva @targos @danielleadams