Skip to content

replace forEach with for loop #49794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ram1607 wants to merge 4 commits into from
Closed

replace forEach with for loop #49794

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
492891e
Replace forEach with for loop
Ram1607 Sep 22, 2023
bdda894
uses for... loop instead of index based loop
Ram1607 Sep 22, 2023
c6b6633
Remove trailing spaces
Ram1607 Sep 22, 2023
8f062fe
Remove extra spaces
Ram1607 Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/parallel/test-dgram-socket-buffer-size.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,17 +93,17 @@ function getExpectedError(type) {
const socket = dgram.createSocket('udp4');

socket.bind(common.mustCall(() => {
badBufferSizes.forEach((badBufferSize) => {
for (const badBufferSize of badBufferSizes) {
assert.throws(() => {
socket.setRecvBufferSize(badBufferSize);
}, errorObj);

Comment thread
Ram1607 marked this conversation as resolved.
Outdated
assert.throws(() => {
socket.setSendBufferSize(badBufferSize);
}, errorObj);
});
}
socket.close();
}));
}));
Comment thread
Ram1607 marked this conversation as resolved.
Outdated
}

{
Expand Down