Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 8 additions & 16 deletions lib/internal/fs/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -461,51 +461,43 @@ const lazyDateFields = {
enumerable: true,
configurable: true,
get() {
const value = dateFromMs(this.atimeMs);
ObjectDefineProperty(this, 'atime', { __proto__: null, value });
return this.atime;
return this.atime = dateFromMs(this.atimeMs);
},
set(value) {
this.atime = value;
ObjectDefineProperty(this, 'atime', { __proto__: null, value, writable: true });
},
},
mtime: {
__proto__: null,
enumerable: true,
configurable: true,
get() {
const value = dateFromMs(this.mtimeMs);
ObjectDefineProperty(this, 'mtime', { __proto__: null, value });
return this.mtime;
return this.mtime = dateFromMs(this.mtimeMs);
},
set(value) {
this.mtime = value;
ObjectDefineProperty(this, 'mtime', { __proto__: null, value, writable: true });
},
},
ctime: {
__proto__: null,
enumerable: true,
configurable: true,
get() {
const value = dateFromMs(this.ctimeMs);
ObjectDefineProperty(this, 'ctime', { __proto__: null, value });
return this.ctime;
return this.ctime = dateFromMs(this.ctimeMs);
},
set(value) {
this.ctime = value;
ObjectDefineProperty(this, 'ctime', { __proto__: null, value, writable: true });
},
},
birthtime: {
__proto__: null,
enumerable: true,
configurable: true,
get() {
const value = dateFromMs(this.birthtimeMs);
ObjectDefineProperty(this, 'birthtime', { __proto__: null, value });
return this.birthtime;
return this.birthtime = dateFromMs(this.birthtimeMs);
},
set(value) {
this.birthtime = value;
ObjectDefineProperty(this, 'birthtime', { __proto__: null, value, writable: true });
},
},
};
Expand Down
32 changes: 32 additions & 0 deletions test/parallel/test-fs-stat.js
Original file line number Diff line number Diff line change
Expand Up @@ -179,3 +179,35 @@ fs.lstat(__filename, undefined, common.mustCall());
]
});
}

// Stat Date properties can be set before reading them
fs.stat(__filename, common.mustSucceed((s) => {
s.atime = 2;
s.mtime = 3;
s.ctime = 4;
s.birthtime = 5;

assert.strictEqual(s.atime, 2);
assert.strictEqual(s.mtime, 3);
assert.strictEqual(s.ctime, 4);
assert.strictEqual(s.birthtime, 5);
}));

// Stat Date properties can be set after reading them
fs.stat(__filename, common.mustSucceed((s) => {
var _;
_ = s.atime;
_ = s.mtime;
_ = s.ctime;
_ = s.birthtime;

s.atime = 2;
s.mtime = 3;
s.ctime = 4;
s.birthtime = 5;

assert.strictEqual(s.atime, 2);
assert.strictEqual(s.mtime, 3);
assert.strictEqual(s.ctime, 4);
assert.strictEqual(s.birthtime, 5);
}));