Skip to content

Use js 'standard' formatter on pre-commit#172

Merged
fhemberger merged 2 commits intomasterfrom
standard-js
Sep 21, 2015
Merged

Use js 'standard' formatter on pre-commit#172
fhemberger merged 2 commits intomasterfrom
standard-js

Conversation

@fhemberger
Copy link
Copy Markdown
Contributor

Closes #157 and #159.

package.json Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the old lint script and explicit eslint dep below?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aye!

@phillipj
Copy link
Copy Markdown
Member

LGTM

@phillipj
Copy link
Copy Markdown
Member

.eslintrc could be deleted aswell

NOTICE: Don't reformat scripts in ./static (may be already minified)
@fhemberger
Copy link
Copy Markdown
Contributor Author

Removed .eslintrc.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be https://github.com/nodejs/node/blob/${version}/CHANGELOG.md?

@fhemberger
Copy link
Copy Markdown
Contributor Author

@nodejs/website Should we merge this?

@mikeal
Copy link
Copy Markdown
Contributor

mikeal commented Sep 21, 2015

+1

fhemberger added a commit that referenced this pull request Sep 21, 2015
Use js 'standard' formatter on pre-commit
@fhemberger fhemberger merged commit 6b4f4fe into master Sep 21, 2015
@fhemberger fhemberger deleted the standard-js branch September 21, 2015 15:57
@zeke
Copy link
Copy Markdown
Contributor

zeke commented Sep 21, 2015

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants