Remove trailing spaces.#2471
Merged
SEWeiTung merged 17 commits intonodejs:masterfrom Sep 5, 2019
XhmikosR:master-xmr-rm-trailing-spaces
Merged
Remove trailing spaces.#2471SEWeiTung merged 17 commits intonodejs:masterfrom XhmikosR:master-xmr-rm-trailing-spaces
SEWeiTung merged 17 commits intonodejs:masterfrom
XhmikosR:master-xmr-rm-trailing-spaces
Conversation
SEWeiTung
requested review from
3imed-jaberi,
Aissaoui-Ahmed and
celyes
and removed request for
Aissaoui-Ahmed
SEWeiTung
approved these changes
Sep 5, 2019
Contributor
SEWeiTung
left a comment
SEWeiTung
left a comment
There was a problem hiding this comment.
LGTM for formation changes only.
Contributor
|
@XhmikosR , forcely push your submit, there're conflicts ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also enable the markdowlint rule to check for this.
I split the patches by locale so that it's easier to review.
The easiest way to review this is to check the rich diff of each file. I already checked most files and everything seems good, but more eyes is always better.
An alternative way, would be to move each patch to each own PR and when we are done, we enable the Markdownlint rule to enforce this.