Skip to content

fix(doc-kit): 'property' to the code like array#8705

Open
avivkeller wants to merge 1 commit intomainfrom
property
Open

fix(doc-kit): 'property' to the code like array#8705
avivkeller wants to merge 1 commit intomainfrom
property

Conversation

@avivkeller
Copy link
Member

Fixes partially code-like text, i.e.:
image

Signed-off-by: Aviv Keller <me@aviv.sh>
Copilot AI review requested due to automatic review settings March 7, 2026 20:50
@avivkeller avivkeller requested a review from a team as a code owner March 7, 2026 20:50
@vercel
Copy link

vercel bot commented Mar 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Mar 7, 2026 8:50pm

Request Review

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the UI components’ “code-like heading” detection so doc-kit headings tagged as property are styled consistently as code-like (e.g., in TOC / meta navigation).

Changes:

  • Add 'property' to the CODE_LIKE_TYPES set used to apply code-like link styling.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.09%. Comparing base (82684bc) to head (a642089).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8705      +/-   ##
==========================================
- Coverage   75.10%   75.09%   -0.01%     
==========================================
  Files         104      104              
  Lines        9161     9162       +1     
  Branches      315      315              
==========================================
  Hits         6880     6880              
- Misses       2279     2280       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.51 MB
New Total Size 3.51 MB
Delta 11.00 B (0.00%)

Changes

➕ Added Assets (2)
Name Size
.next/static/chunks/f62865bdfb05e0e1.js 208.15 KB
.next/static/chunks/afc03cd6290b8b45.js 36.52 KB
➖ Removed Assets (2)
Name Size
.next/static/chunks/3d46284d5f545833.js 208.15 KB
.next/static/chunks/810340e79c93109b.js 36.51 KB

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, happy to fast-track too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants