fix: check result when determining exit code of ls <filter>#1986
Closed
G-Rath wants to merge 1 commit intonpm:latestfrom
G-Rath:fix-empty-ls-results-check
Closed
fix: check result when determining exit code of ls <filter>#1986G-Rath wants to merge 1 commit intonpm:latestfrom G-Rath:fix-empty-ls-results-check
result when determining exit code of ls <filter>#1986G-Rath wants to merge 1 commit intonpm:latestfrom
G-Rath:fix-empty-ls-results-check
Conversation
Contributor
|
This LGTM. |
isaacs
reviewed
Oct 20, 2020
Contributor
isaacs
left a comment
isaacs
left a comment
There was a problem hiding this comment.
One nit that we can definitely squash out at release time if you don't feel like updating and pushing. Otherwise LGTM.
ruyadorno
approved these changes
Oct 20, 2020
darcyclarke
added
the
release: next
Merged
Contributor
|
Thanks @G-Rath 🎉 landed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alright, take two (because I didn't realise you can't reopen PRs after force pushing 🤦)
I've chucked an assertion to prevent regression into the first filter test - technically they should all ideally do the check, but I've not worked a lot with tap and this is a simple typo bug that I don't expect would crop up all the time.
Happy to add the assertion to the other tests if desired :)
References
Fixes #1979