Skip to content

build: fix build order#985

Open
huang-julien wants to merge 1 commit intomainfrom
build/build_order
Open

build: fix build order#985
huang-julien wants to merge 1 commit intomainfrom
build/build_order

Conversation

@huang-julien
Copy link
Copy Markdown
Member

🔗 Linked issue

https://github.com/nuxt/devtools/actions/runs/24111824283/job/70347835615

📚 Description

Seems like turbo is running step for all packages in parallel but devtools requires devtools-kit to be built first

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying nuxt-devtools with  Cloudflare Pages  Cloudflare Pages

Latest commit: c69b295
Status: ✅  Deploy successful!
Preview URL: https://c64d3bf4.nuxt-devtools.pages.dev
Branch Preview URL: https://build-build-order.nuxt-devtools.pages.dev

View logs

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 053c76ee-3336-4ec9-b020-3d2b1dd58450

📥 Commits

Reviewing files that changed from the base of the PR and between 7bf7b36 and c69b295.

📒 Files selected for processing (1)
  • turbo.json

📝 Walkthrough

Walkthrough

The turbo.json file was updated to add an explicit dependsOn declaration to the build task. The task now specifies dependsOn: ["^build"], which creates a dependency relationship requiring all upstream or ancestor projects to complete their build tasks before the current project's build task executes. This alters the task execution order within the monorepo build pipeline without modifying any other task configurations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'build: fix build order' directly summarizes the main change: fixing the build order by adding explicit dependencies in turbo.json to ensure sequential building.
Description check ✅ Passed The description explains the problem (turbo running steps in parallel) and the intended solution (ensuring devtools-kit builds before devtools), which aligns with the changeset that adds dependency declarations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch build/build_order

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@huang-julien huang-julien requested a review from antfu April 10, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant