Merged
Conversation
ja5087
reviewed
Nov 26, 2020
Member
ja5087
left a comment
ja5087
left a comment
There was a problem hiding this comment.
wow, this is really impressive in scale
| @@ -0,0 +1,72 @@ | |||
| apiVersion: v1 | |||
Member
There was a problem hiding this comment.
If this is templated by our convention it should end in .erb
Contributor
Author
There was a problem hiding this comment.
It would by the convention, but then you lose syntax highlighting on github and in your editor. I'm willing to change it, but I personally think it's fine as long as people know it's an erb template.
Member
There was a problem hiding this comment.
imo it is not clear at all that it's an erb template outside of us in the know right now. You can configure syntax highlighting for different file extensions in your editor and there are cases where that will be wrong due to special characters that overlap between erb and the target language. YAML is pretty simple though so there might not be one in this case.
Errored hosts (0)Changed hosts (6)Unaffected hosts (95)WARNING: Output is too long for a comment, posted to a gist instead: https://gist.github.com/1001b6a5845b6733e2216a848ce50f25 |
Errored hosts (6)Changed hosts (0)Unaffected hosts (95)Errored hostserror for hozer-72.ocf.berkeley.eduerror for hozer-73.ocf.berkeley.eduerror for hozer-74.ocf.berkeley.eduerror for monsoon.ocf.berkeley.eduerror for pileup.ocf.berkeley.eduerror for whirlwind.ocf.berkeley.eduUnaffected hosts |
Literally just forgot to do this
This reverts commit d5f9645.
Co-authored-by: Christopher Cooper <cooperc@ocf.berkeley.edu>
* add bullseye to distributions * disable puppetlabs repo for bullseye * add bullseye-backports
ja5087
approved these changes
Dec 31, 2020
Member
ja5087
left a comment
ja5087
left a comment
There was a problem hiding this comment.
Before it went down I think this was working pretty well. Merging it will let other people work on this easier too and avoid us having things on different puppet envs (cooperc2).
| @@ -0,0 +1,72 @@ | |||
| apiVersion: v1 | |||
Member
There was a problem hiding this comment.
imo it is not clear at all that it's an erb template outside of us in the know right now. You can configure syntax highlighting for different file extensions in your editor and there are cases where that will be wrong due to special characters that overlap between erb and the target language. YAML is pretty simple though so there might not be one in this case.
Errored hosts (0)Changed hosts (32)Unaffected hosts (56)WARNING: Output is too long for a comment, posted to a gist instead: https://gist.github.com/5b892a3ac0efb42c36619f9fe7e43ef2 |
Errored hosts (0)Changed hosts (2)Unaffected hosts (86)WARNING: Output is too long for a comment, posted to a gist instead: https://gist.github.com/ef19c85b8f1d7586ba0170fb14a8a719 |
Member
|
🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rewrite of the existing kubernetes setup from puppetlabs-kubernetes to manually configured services and configuration files.