Skip to content

ofParameter<void>::trigger() notifies parents#6471

Merged
arturoc merged 1 commit intoopenframeworks:masterfrom
PlaymodesStudio:feature-ofParameter_void_notify_parents
Dec 12, 2019
Merged

ofParameter<void>::trigger() notifies parents#6471
arturoc merged 1 commit intoopenframeworks:masterfrom
PlaymodesStudio:feature-ofParameter_void_notify_parents

Conversation

@eduardfrigola
Copy link
Copy Markdown
Contributor

Implements what is discussed in: #6467

@ofTheo ofTheo mentioned this pull request Dec 1, 2019
48 tasks
@ofTheo ofTheo added this to the 0.11.1 milestone Dec 1, 2019
@arturoc arturoc merged commit 0e0a59f into openframeworks:master Dec 12, 2019
@arturoc
Copy link
Copy Markdown
Member

arturoc commented Dec 12, 2019

thanks!

@eduardfrigola eduardfrigola deleted the feature-ofParameter_void_notify_parents branch December 13, 2019 20:33
oxillo pushed a commit to oxillo/openFrameworks that referenced this pull request Dec 21, 2019
eduardfrigola added a commit to PlaymodesStudio/openFrameworks that referenced this pull request Apr 22, 2020
@eduardfrigola
Copy link
Copy Markdown
Contributor Author

Sorry to bring back this old issue, but I see two problems in here.
As it is a 0.11.1 milestone issue, it should have been requested against patch-release and not into master... I don't know how to fix this... Can this be fixed? Does this have to be removed from the 0.11.1 milestone?
Another problem is that the code in this pull request introduced an issue #6602, and i think that should be resolved to be able to mark the milestone as completed.

Sorry about those mistakes, let me now what I can do to address them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants