Skip to content

Rabbitmq vhost and user support#848

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
lmiccini:rabbitmq_vhosts
Feb 6, 2026
Merged

Rabbitmq vhost and user support#848
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
lmiccini:rabbitmq_vhosts

Conversation

@lmiccini
Copy link
Copy Markdown
Contributor

@lmiccini lmiccini commented Dec 16, 2025

Add new notificationsBus interface to hold cluster, user and vhost names for optional usage.
The controller adds these values to the TransportURL create request when present.

Additionally, we migrate RabbitMQ cluster name to RabbitMq config struct
using DefaultRabbitMqConfig from infra-operator to automatically
populate the new Cluster field from legacy RabbitMqClusterName.

Example usage:

  spec:
    notificationsBus:
      cluster: rabbitmq
      user: custom-user
      vhost: custom-vhost

Jira: https://issues.redhat.com/browse/OSPRH-23739

Depends-on: openstack-k8s-operators/openstack-operator#1797

@openshift-ci openshift-ci bot requested review from konan-abhi and viroel December 16, 2025 14:51
Comment thread api/v1beta1/glance_types.go Outdated
Comment thread api/v1beta1/glance_types.go Outdated
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/601cedbf021e4bff9c9a114ac9f26b70

openstack-k8s-operators-content-provider FAILURE in 7m 53s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@lmiccini lmiccini force-pushed the rabbitmq_vhosts branch 3 times, most recently from dbc55cf to 6548abe Compare December 19, 2025 13:01
@softwarefactory-project-zuul
Copy link
Copy Markdown

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/glance-operator for 848,44cb2756c4c1c090181e7c55ed7b2c46c688fa5a

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/66740c5a23c9497590a6bab625ca711f

openstack-k8s-operators-content-provider FAILURE in 6m 12s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/55a6e18cecfc4181a45c0c4f4374b746

openstack-k8s-operators-content-provider FAILURE in 5m 13s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Comment thread test/functional/glance_webhook_test.go
@lmiccini lmiccini force-pushed the rabbitmq_vhosts branch 2 times, most recently from 08a233a to 7d867f4 Compare January 26, 2026 08:22
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/35706b94b9c84eb0a1eae801b4364f55

openstack-k8s-operators-content-provider FAILURE in 15m 29s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@lmiccini
Copy link
Copy Markdown
Contributor Author

check-rdo

@lmiccini
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/21c6803cd7854ce4bcd5fc3aa7414506

openstack-k8s-operators-content-provider FAILURE in 16m 20s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@lmiccini
Copy link
Copy Markdown
Contributor Author

recheck

@lmiccini
Copy link
Copy Markdown
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8eab1a8986334dedb35197c3f1cae214

openstack-k8s-operators-content-provider FAILURE in 17m 26s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7d48727490c2427e861accf8e8dc6fa9

openstack-k8s-operators-content-provider FAILURE in 9m 38s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/805eb929e50340cf878fda018bd6d1c7

openstack-k8s-operators-content-provider FAILURE in 11m 41s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5a4ae1d12613420483a3e071fd66bc21

openstack-k8s-operators-content-provider FAILURE in 14m 11s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/87896a4cb6274eb89105402253c70f56

openstack-k8s-operators-content-provider FAILURE in 12m 19s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@lmiccini
Copy link
Copy Markdown
Contributor Author

lmiccini commented Feb 2, 2026

recheck

Add new notificationsBus interface to hold cluster, user and vhost names for optional usage.
The controller adds these values to the TransportURL create request when present.

Additionally, we migrate RabbitMQ cluster name to RabbitMq config struct
using DefaultRabbitMqConfig from infra-operator to automatically
populate the new Cluster field from legacy RabbitMqClusterName.

Example usage:

  spec:
    notificationsBus:
      cluster: rabbitmq
      user: custom-user
      vhost: custom-vhost

Jira: https://issues.redhat.com/browse/OSPRH-23739
@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/48202057387548478d35312987a5c140

openstack-k8s-operators-content-provider FAILURE in 12m 58s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@lmiccini
Copy link
Copy Markdown
Contributor Author

lmiccini commented Feb 4, 2026

recheck

@softwarefactory-project-zuul
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/efbd453d572642a59ab9f781e35e9d32

openstack-k8s-operators-content-provider FAILURE in 4m 57s
⚠️ glance-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ glance-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@lmiccini
Copy link
Copy Markdown
Contributor Author

lmiccini commented Feb 4, 2026

recheck

Copy link
Copy Markdown
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, lmiccini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 6, 2026
@fmount
Copy link
Copy Markdown
Contributor

fmount commented Feb 6, 2026

/override precommit-check

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 6, 2026

@fmount: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • precommit-check

Only the following failed contexts/checkruns were expected:

  • ci/prow/functional
  • ci/prow/images
  • ci/prow/precommit-check
  • pull-ci-openstack-k8s-operators-glance-operator-18.0-fr4-functional
  • pull-ci-openstack-k8s-operators-glance-operator-18.0-fr4-images
  • pull-ci-openstack-k8s-operators-glance-operator-18.0-fr4-precommit-check
  • rdoproject.org/github-check
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fmount
Copy link
Copy Markdown
Contributor

fmount commented Feb 6, 2026

/override ci/prow/precommit-check

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 6, 2026

@fmount: Overrode contexts on behalf of fmount: ci/prow/precommit-check

Details

In response to this:

/override ci/prow/precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit e0a322f into openstack-k8s-operators:main Feb 6, 2026
6 checks passed
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 6, 2026

@lmiccini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/functional 02f38e6 link unknown /test functional

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants