Skip to content

[18.0-fr5] Remove go.work before container build#1883

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:18.0-fr5from
stuggi:remove_go_work_fr5
Apr 13, 2026
Merged

[18.0-fr5] Remove go.work before container build#1883
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:18.0-fr5from
stuggi:remove_go_work_fr5

Conversation

@stuggi
Copy link
Copy Markdown
Contributor

@stuggi stuggi commented Apr 13, 2026

The go.work file is generated by the CI environment which may have a higher Go version than the build image (go-toolset). This causes build failures when go.work references a Go version that the build image does not provide. Since the Dockerfile builds a single module, go.work is not needed and can be safely removed before building.

(cherry picked from commit 540876a)

The go.work file is generated by the CI environment which may have a
higher Go version than the build image (go-toolset). This causes build
failures when go.work references a Go version that the build image
does not provide. Since the Dockerfile builds a single module, go.work
is not needed and can be safely removed before building.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
(cherry picked from commit 540876a)
@openshift-ci openshift-ci bot requested review from rabi and rebtoor April 13, 2026 06:20
@github-actions
Copy link
Copy Markdown

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 322199 bytes (315KB)
Base branch size 322199 bytes
Change +0.00%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

@stuggi stuggi requested review from abays and fmount and removed request for rebtoor April 13, 2026 06:31
Copy link
Copy Markdown
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm label Apr 13, 2026
@stuggi
Copy link
Copy Markdown
Contributor Author

stuggi commented Apr 13, 2026

/retest

@stuggi
Copy link
Copy Markdown
Contributor Author

stuggi commented Apr 13, 2026

build went fine. I'll override failing jobs on later test errors as they are not related to this change in the Dockerfile.

@stuggi
Copy link
Copy Markdown
Contributor Author

stuggi commented Apr 13, 2026

/override ci/prow/openstack-operator-build-deploy-kuttl-4-18

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 13, 2026

@stuggi: Overrode contexts on behalf of stuggi: ci/prow/openstack-operator-build-deploy-kuttl-4-18

Details

In response to this:

/override ci/prow/openstack-operator-build-deploy-kuttl-4-18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stuggi
Copy link
Copy Markdown
Contributor Author

stuggi commented Apr 13, 2026

/override rdoproject.org/github-check

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 13, 2026

@stuggi: Overrode contexts on behalf of stuggi: rdoproject.org/github-check

Details

In response to this:

/override rdoproject.org/github-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit f3dc049 into openstack-k8s-operators:18.0-fr5 Apr 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants