Skip to content

[18.0-fr5] Fix stale SecretHashes on nodeset status after node removal#1886

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:18.0-fr5from
openshift-cherrypick-robot:cherry-pick-1849-to-18.0-fr5
Apr 14, 2026
Merged

[18.0-fr5] Fix stale SecretHashes on nodeset status after node removal#1886
openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:18.0-fr5from
openshift-cherrypick-robot:cherry-pick-1849-to-18.0-fr5

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Apr 14, 2026

This is an automated cherry-pick of #1849

/assign rabi

@rabi
Fix stale SecretHashes on nodeset status after node removal
7540452 
When a node is removed from a nodeset and a full deployment
(no ServicesOverride) succeeds, overwrite the nodeset's
SecretHashes with the deployment's hashes instead of merging.
This drops stale TLS cert secret hash entries for the removed
node. Partial deployments (with ServicesOverride) continue to
merge additively to preserve hashes from other deployments.

Change-Id: I12abffa18af63b14630f80f5a0e6235158f4a9ef
Signed-off-by: rabi <ramishra@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 14, 2026
Merged
@openshift-ci openshift-ci bot requested review from dprince and rabi April 14, 2026 05:44
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

OpenStackControlPlane CRD Size Report

Metric Value
CRD JSON size 322199 bytes (315KB)
Base branch size 322199 bytes
Change +0.00%
Status yellow — growing
Threshold reference
Color Range Meaning
🟢 green < 300KB Comfortable
🟡 yellow 300–400KB Growing
🟠 orange 400–750KB Concerning
🔴 red > 750KB Approaching 1.5MB etcd limit (cut in half to allow space for update)

@softwarefactory-project-zuul
Copy link
Copy Markdown

softwarefactory-project-zuul bot commented Apr 14, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d960cbfa6f2c4894a1f1bfc69a479e8b

❌ openstack-k8s-operators-content-provider FAILURE in 4m 16s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-edpm-baremetal-minor-update SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@openshift-ci openshift-ci bot added the lgtm label Apr 14, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rabi
Copy link
Copy Markdown
Contributor

rabi commented Apr 14, 2026

recheck

@openshift-merge-bot openshift-merge-bot bot merged commit bad54ec into openstack-k8s-operators:18.0-fr5 Apr 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rabi rabi rabi approved these changes

@dprince dprince Awaiting requested review from dprince

Assignees

@rabi rabi

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@openshift-cherrypick-robot @rabi