Conversation
f2par0
commented
Feb 5, 2026
- Change version to 1.0.0-SNAPSHOT for Jakarta branch
- Replace javax.* dependencies with jakarta.* equivalents:
- javax.transaction-api 1.2 -> jakarta.transaction-api 2.0.1
- javax.enterprise.cdi-api -> jakarta.enterprise.cdi-api
- javax.interceptor-api -> jakarta.interceptor-api
- javax.jms-api 2.0.1 -> jakarta.jms-api 3.1.0
- javax.resource-api -> jakarta.resource-api 2.1.0
- org.apache.servicemix.bundles.javax-inject removed (use jakarta.inject)
- Restore narayana osgi support
- Change version to 1.0.0-SNAPSHOT for Jakarta branch - Replace javax.* dependencies with jakarta.* equivalents: - javax.transaction-api 1.2 -> jakarta.transaction-api 2.0.1 - javax.enterprise.cdi-api -> jakarta.enterprise.cdi-api - javax.interceptor-api -> jakarta.interceptor-api - javax.jms-api 2.0.1 -> jakarta.jms-api 3.1.0 - javax.resource-api -> jakarta.resource-api 2.1.0 - org.apache.servicemix.bundles.javax-inject removed (use jakarta.inject) - Restore narayana osgi support
| <feature name="pax-transx-tm-narayana" version="${project.version}"> | ||
| <feature>pax-transx-tm-api</feature> | ||
| <bundle dependency="true">wrap:mvn:org.jboss.narayana.jta/narayana-jta/${version.org.jboss.narayana}</bundle> | ||
| <bundle dependency="true">wrap:mvn:org.jboss.narayana.jts/narayana-jts-integration/${version.org.jboss.narayana}</bundle> |
There was a problem hiding this comment.
narayana doesn't provide osgi support in 7.3.3 : the previous narayana-osgi-jta doesn't exist anymore . So I added the jar wrapped as bundles and added the few files specific of osgi in this repo.
I have to rework this to have everything in the same bundle instead of using wrap protocol
There was a problem hiding this comment.
fixed in this commit
I used the ShadowNoFileLockStore which is the default one to avoid to pull all the hornetq dependencies that were previously embedded in narayana-osgi-jta (artemis-journal, commons, netty ...) . If necessary I can restore this too
|
|
||
| <!-- APIs --> | ||
|
|
||
| <!-- pax exam is not yet jakarta EE compatible, so we need javax.inject --> |
There was a problem hiding this comment.
I use Pax Exam in Pax Web 11...
Pax Exam should be agnostic to javax/jakarta...
| <version.org.apache.activemq>5.16.6</version.org.apache.activemq> | ||
| <version.org.apache.aries.transaction>1.3.3</version.org.apache.aries.transaction> | ||
| <version.org.apache.activemq>6.2.0</version.org.apache.activemq> | ||
| <version.org.apache.aries.transaction>2.0.0-SNAPSHOT</version.org.apache.aries.transaction> |
There was a problem hiding this comment.
this is to be changed to the release of aries which includes jakarta.( after merge of apache/aries#790)
| <version.org.apache.karaf>4.2.16</version.org.apache.karaf> | ||
| <version.org.apache.felix.framework>7.0.5</version.org.apache.felix.framework> | ||
| <version.org.apache.geronimo.transaction>4.0.0</version.org.apache.geronimo.transaction> | ||
| <version.org.apache.karaf>4.4.8</version.org.apache.karaf> |
There was a problem hiding this comment.
Karaf 4.4 is not based on Jakarta EE 9+...
There was a problem hiding this comment.
it's not based on Jarkarta EE 9+ , but at least it provides some more recent dependencies that if I let it in 4.2.16
|
Thanks @f2par0 - I really didn't have much time to move this project (and Pax JMS) to jakarta after huge (few years) effort to do that for Pax Web. I know it has to be done. Your PR looks like does the migration, but it's very hard for me to review one commit which changes tests, changes imported packages, changes versions and changes groupId/artifactId of so many dependencies... I understand that some situations require commit squashing (especially if you use more commits with the same name), but sometimes it's really helpful to commit the changes separately, so they can be reviewed in isolation... The PR for Aries is even bigger and I'd like to wait for other active Aries devs to review too. If Aries doesn't work yet with I've added my comments, but tbh I don't think we should merge as is. It took me >3 years to make Pax Web compatible with jakarta packages. I don't say you should do the same, but we should do at least more than one commit with more careful review. |
|
https://geronimo.apache.org/ says:
and
I don't see a reference to Transaction Manager in Geronimo site - even if I do see it in Maven Central (version 4.0.0). |
Hello @grgrzybek , thanks for the comments, it pointed to some mistakes I did.
Let me know, it it would be helpful, I could apply the same for aries and jms repo |
That's right, the 4.0.0 is from 2003, no more activity on the repo since then. Do you want to remove support for it from pax.transx ? |
|
Sorry for no feedback @f2par0 ... I really don't have much time recently... |