Simplifiy configuration to build using std C++17#3219
Merged
airween merged 1 commit intoowasp-modsecurity:v3/masterfrom Aug 9, 2024
Merged
Simplifiy configuration to build using std C++17#3219airween merged 1 commit intoowasp-modsecurity:v3/masterfrom
airween merged 1 commit intoowasp-modsecurity:v3/masterfrom
Conversation
- Leveraged autoconf again to check whether the C++ compiler supports the required standard version and build using it. - Replaced the outdaded `ax_cxx_compile_stdcxx_11.m4` macro with the latest version of `ax_cxx_compile_stdcxx` which supports C++17. - https://www.gnu.org/software/autoconf-archive/ax_cxx_compile_stdcxx.html - https://raw.githubusercontent.com/autoconf-archive/autoconf-archive/e4e5269db2764b9f53d759c24750ac6ca38e02ea/m4/ax_cxx_compile_stdcxx.m4 - This should also streamline updating to C++20 in the future.
Contributor
Author
I've already tested this on a separate branch, which requires only the change to the following line in NOTE: And also a similar change in |
|
eduar-hte
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Leveraged autoconf again to check whether the C++ compiler supports the required standard version and build using it.
why
Simplify std C++ used to build libModSecurity codebase to minimize configuration that depends on this setting.
This streamlines updating to C++20 in the future as it needs to be changed in a single place.
changes
ax_cxx_compile_stdcxx_11.m4macro with the latest version ofax_cxx_compile_stdcxxwhich supports C++17.references
The project configuration was bumped to C++17 in PR #3079 (see commit 367a871).