Conversation
Potherca
approved these changes
Mar 11, 2026
Member
Potherca
left a comment
Potherca
left a comment
There was a problem hiding this comment.
Only minor nitpicks, feel free to ignore.
|
|
||
| public static function getUserByWebId($webId) { | ||
| $idParts = explode(".", $webId, 2); | ||
| if ($idParts[1] !== BASEDOMAIN . "/#me") { |
Member
There was a problem hiding this comment.
Is there a scenario where the provided $webId does not have #me appended?
Otherwise if ( ! str_starts_with( $idParts[1], BASEDOMAIN)) { feels more appropriate
| "openapi": "3.0.0", | ||
| "info": { | ||
| "description": "API documentation for PHP Solid Storage Provider", | ||
| "version": "0.1", |
| "title": "PHP Solid Storage Provider API", | ||
| "license": { | ||
| "name": "Copyright PDSInterop", | ||
| "url": "http://solid.local/api/v1/LICENSE" |
Member
There was a problem hiding this comment.
Should be https://pdsinterop.org/license/?
| "version": "0.1", | ||
| "title": "PHP Solid Storage Provider API", | ||
| "license": { | ||
| "name": "Copyright PDSInterop", |
Member
There was a problem hiding this comment.
Minor nitpick, missing space PDS Interop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.