Skip to content

dev doc: update the example of paginate results#20449

Merged
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
yiduoyunQ:master
Jun 4, 2025
Merged

dev doc: update the example of paginate results#20449
ti-chi-bot[bot] merged 2 commits intopingcap:masterfrom
yiduoyunQ:master

Conversation

@yiduoyunQ
Copy link
Copy Markdown
Contributor

@yiduoyunQ yiduoyunQ commented Jun 3, 2025

fix sql

First-time contributors' checklist

What is changed, added or deleted? (Required)

fix sql

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 3, 2025
@hfxsd hfxsd self-assigned this Jun 3, 2025
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed missing-translation-status This PR does not have translation status info. labels Jun 3, 2025
@hfxsd hfxsd added ONCALL Relates to documentation oncall. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jun 3, 2025
@hfxsd hfxsd requested review from YangKeao and hfxsd June 3, 2025 09:24
@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Jun 4, 2025

/bot-review

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 4, 2025

✅ AI review completed, 3 comments generated.

@hfxsd hfxsd changed the title Update dev-guide-paginate-results.md dev doc: update the example of paginate results Jun 4, 2025
Copy link
Copy Markdown
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Jun 4, 2025

@YangKeao: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Jun 4, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-04 02:25:23.668318158 +0000 UTC m=+408609.870663421: ☑️ agreed by hfxsd.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 4, 2025
@hfxsd hfxsd added the lgtm label Jun 4, 2025
@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Jun 4, 2025

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 4, 2025
@ti-chi-bot ti-chi-bot bot merged commit 1d604d6 into pingcap:master Jun 4, 2025
7 checks passed
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20451.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20452.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/develop This PR relates to the area of TiDB App development. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ONCALL Relates to documentation oncall. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants