Skip to content

dumpling: update privilege related section#20466

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
joechenrh:update-dumpling
Jun 5, 2025
Merged

dumpling: update privilege related section#20466
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
joechenrh:update-dumpling

Conversation

@joechenrh
Copy link
Copy Markdown
Contributor

@joechenrh joechenrh commented Jun 5, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

The privilege section of dumpling is misleading.

  • First, MySQL also has RELOAD privilege.
  • Second, --consistency flush can't apply to TiDB.

https://github.com/pingcap/tidb/blob/23de08cfb549df008edd69f3a9a7313ab18ecff3/dumpling/export/consistency.go#L93-L98

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2025
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Jun 5, 2025
@hfxsd hfxsd self-assigned this Jun 5, 2025
@hfxsd hfxsd self-requested a review June 5, 2025 01:58
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Jun 5, 2025

@D3Hunter: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 5, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 5, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Jun 5, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-05 02:23:34.099501346 +0000 UTC m=+494900.301846611: ☑️ agreed by tangenta.
  • 2025-06-05 02:30:11.782859069 +0000 UTC m=+495297.985204328: ☑️ agreed by hfxsd.

@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed translation/doing This PR’s assignee is translating this PR. labels Jun 5, 2025
@hfxsd
Copy link
Copy Markdown
Collaborator

hfxsd commented Jun 5, 2025

/approve

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Jun 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 5, 2025
@ti-chi-bot ti-chi-bot bot merged commit 188c825 into pingcap:master Jun 5, 2025
7 checks passed
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20467.

JaySon-Huang pushed a commit to JaySon-Huang/docs-cn that referenced this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants