Skip to content

refresh TopSQL docs and screenshots#21431

Open
yibin87 wants to merge 22 commits intopingcap:masterfrom
yibin87:update_topsql_functionality
Open

refresh TopSQL docs and screenshots#21431
yibin87 wants to merge 22 commits intopingcap:masterfrom
yibin87:update_topsql_functionality

Conversation

@yibin87
Copy link
Copy Markdown
Contributor

@yibin87 yibin87 commented Mar 11, 2026

What is changed, added or deleted? (Required)

  • Refresh dashboard/top-sql.md to match the current pingcap/tidb-dashboard master behavior.
  • Update the Top SQL doc to cover Top 5/20/100, CPU/Network/Logical IO ordering, TiKV By Query / By Table / By DB / By Region, and the enable/disable behavior for TiKV network IO collection.
  • Re-shoot and replace the Top SQL screenshots with the current UI, including the TiKV Order By Network and Order By Logical IO views.
  • Add two new screenshots to explicitly show the Order By dropdown and the Top SQL settings drawer for enabling TiKV Network IO collection.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 11, 2026
@yibin87
Copy link
Copy Markdown
Contributor Author

yibin87 commented Mar 11, 2026

/cc @zhaoshangzi

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 11, 2026

@yibin87: GitHub didn't allow me to request PR reviews from the following users: zhaoshangzi.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @zhaoshangzi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yibin87 yibin87 requested review from hfxsd and nolouch March 11, 2026 09:19
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 11, 2026

@nolouch: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Mar 12, 2026
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Mar 12, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 12, 2026

@zhaoshangzi: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: yibin87 <huyibin@pingcap.com>
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 12, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 12, 2026

@zhaoshangzi: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Mar 30, 2026
@Oreoxmt
Copy link
Copy Markdown
Collaborator

Oreoxmt commented Apr 3, 2026

/cc @Oreoxmt

@ti-chi-bot ti-chi-bot bot requested a review from Oreoxmt April 3, 2026 03:48
@Oreoxmt Oreoxmt self-requested a review April 10, 2026 02:40
Copy link
Copy Markdown
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Apr 10, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Apr 10, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-04-10 06:27:13.9288221 +0000 UTC m=+1110439.134182158: ☑️ agreed by Oreoxmt.

Co-authored-by: Aolin <aolinz@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants