Add FORMAT_BYTES and FORMAT_NANO_TIME functions#20872
Add FORMAT_BYTES and FORMAT_NANO_TIME functions#20872ti-chi-bot[bot] merged 10 commits intopingcap:masterfrom
Conversation
There was a problem hiding this comment.
Hello @dveeden, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request adds two new utility functions to TiDB: FORMAT_BYTES() and FORMAT_NANO_TIME(). These functions format a number of bytes and nanoseconds, respectively, into human-readable strings. The changes include adding the new functions to the functions-and-operators/utility-functions.md documentation file, as well as updating the table of contents in TOC.md and TOC-tidb-cloud.md to include a link to the new utility functions documentation.
Highlights
- New Functions: Introduces
FORMAT_BYTES()to format byte sizes into human-readable strings (e.g., '10.00 MiB'). - New Functions: Introduces
FORMAT_NANO_TIME()to format nanosecond values into human-readable strings (e.g., '1.00 ms'). - Documentation: Adds a new
utility-functions.mdfile underfunctions-and-operators/to document the new functions. - Table of Contents: Updates
TOC.mdandTOC-tidb-cloud.mdto include a link to the newUtility Functionsdocumentation.
Changelog
- TOC-tidb-cloud.md
- Added 'Utility Functions' to the table of contents, linking to the new documentation page.
- TOC.md
- Added 'Utility Functions' to the table of contents, linking to the new documentation page.
- functions-and-operators/utility-functions.md
- Created a new documentation page for 'Utility Functions'.
- Documented the
FORMAT_BYTES()function with a description and example. - Documented the
FORMAT_NANO_TIME()function with a description and example.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds two new utility functions, FORMAT_BYTES and FORMAT_NANO_TIME, to TiDB's documentation. The changes include adding the function documentation and updating the table of contents. Overall, the changes are well-structured and clear.
Merge Readiness
The pull request is well-structured and clear, and the changes seem straightforward. I recommend merging it after addressing the minor suggestions in the review comments. I am unable to approve this pull request, and that users should have others review and approve this code before merging.
|
Checking the docs against TiDB v8.5.1:
So this is a list of things to check: |
|
Related: pingcap/tidb#60906 Looks like |
|
Also related: pingcap/tidb#60928 |
|
@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?