Revert "Add TiDB 8.5.2 Release Notes"#21122
Conversation
This reverts commit 1c09730.
ti-chi-bot
bot
added
contribution
![gemini-code-assist[bot]](https://avatars.gh.lumenfield.work/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @hfxsd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
Hello! Gemini or gemini-code-assist here to provide a summary of this pull request. This PR, authored by hfxsd, aims to revert the changes introduced in pull request #20834. Based on the title and description, the original PR likely added documentation related to the TiDB 8.5.2 release notes. This current PR undoes those changes, effectively removing references to the 8.5.2 release from the documentation site.
Highlights
- Revert of 8.5.2 Release Notes Addition: This pull request performs a revert of a previous PR (
#20834) that added documentation for the TiDB 8.5.2 release. The changes remove the previously added links and entries for 8.5.2 from the documentation. - Documentation Cleanup: The revert cleans up the documentation by removing references to the 8.5.2 release from the Table of Contents, the main release notes index page, and the release timeline.
Changelog
- TOC.md
- Removed the link to the 8.5.2 release notes from the
v8.5section in the Table of Contents (line 1099).
- Removed the link to the 8.5.2 release notes from the
- releases/release-notes.md
- Removed the entry for the 8.5.2 release from the
## 8.5section on the main release notes page (line 17).
- Removed the entry for the 8.5.2 release from the
- releases/release-timeline.md
- Removed the row corresponding to the 8.5.2 release from the release timeline table (line 16).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
hfxsd
added
translation/from-docs-cn
There was a problem hiding this comment.
Code Review
This pull request correctly reverts the links to the "TiDB 8.5.2 Release Notes" in TOC.md, releases/release-notes.md, and releases/release-timeline.md. The deletions are clean and restore the state prior to the introduction of the 8.5.2 release information in these specific files.
Important Consideration for Completeness:
This PR reverts pingcap/docs#20834. Could you please confirm if the actual release note file, likely releases/release-8.5.2.md, was also added as part of PR #20834?
If so, that file should also be deleted as part of this revert to prevent an orphaned file in the documentation. An orphaned release note file can cause confusion and add to maintenance overhead.
If the file deletion is handled separately or was not part of the original PR, then these changes are fine. Otherwise, please consider adding the file deletion to this PR to ensure a complete revert.
The changes within this PR are clear and effectively achieve the stated goal of reverting the links.
Summary of Findings
- Potential Incomplete Revert: This PR reverts links to the TiDB 8.5.2 release notes from three files. To ensure a complete revert of the original PR (#20834), it's crucial to verify if the
releases/release-8.5.2.mdfile itself was also part of that original PR. If it was, it should ideally be deleted as part of this revert to avoid an orphaned documentation file, which can lead to maintenance issues and potential user confusion.
Merge Readiness
The changes included in this pull request, which involve removing links to the TiDB 8.5.2 release notes, are correctly implemented. However, for this revert to be considered complete, please verify and address the status of the releases/release-8.5.2.md file as mentioned in the general feedback. If that file was part of the original PR #20834, it should also be deleted.
Assuming the completeness of the revert (including the actual release note file if applicable) is confirmed or addressed, the modifications in this PR are otherwise ready. As per standard procedure, I am unable to approve the pull request directly; please ensure it undergoes further review and approval according to your team's workflow before merging.
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
3 participants
Reverts #20834