tidb: add the join order related variable tidb_opt_join_reorder_through_sel (#22477)#22725
Merged
ti-chi-bot[bot] merged 14 commits intopingcap:feature/preview-v8.5.6from Apr 10, 2026
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Aolin <aolinz@outlook.com>
ti-chi-bot
added
contribution
14 tasks
![gemini-code-assist[bot]](https://avatars.gh.lumenfield.work/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces documentation for the new system variable tidb_opt_join_reorder_through_sel, available in versions v8.5.6 and v9.0.0. The variable enables the optimizer to include filter conditions between consecutive joins in the Join Reorder optimization process. Review feedback focuses on improving the readability and logical flow of the documentation by splitting long sentences and rephrasing descriptions to lead with behavior rather than rationale.
ti-chi-bot
bot
added
size/XL
ti-chi-bot
bot
added
size/XXL
This reverts commit 24d4c11.
ti-chi-bot
bot
added
size/XL
This reverts commit a85ec8a.
ti-chi-bot
bot
removed
the
size/XXL
ti-chi-bot
bot
added
the
size/XL
ti-chi-bot
bot
added
size/S
ti-chi-bot
bot
added
size/XL
ti-chi-bot
bot
added
size/S
hfxsd
reviewed
Apr 10, 2026
Collaborator
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hfxsd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
merged commit bd5be4e
into
pingcap:feature/preview-v8.5.6
11 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #22477
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
tidb_opt_join_reorder_through_seldocs-cn#21292Do your changes match any of the following descriptions?