br: add restoreid to idmap table#61278
Conversation
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
ti-chi-bot
bot
added
do-not-merge/needs-tests-checked
release-note-none
|
Hi @Tristan1900. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| } | ||
|
|
||
| // checkOwnerVersion is used to wait the DDL owner to be elected in the cluster and check it is the same version as this TiDB. | ||
| func checkOwnerVersion(ctx context.Context, dom *domain.Domain) (bool, error) { |
There was a problem hiding this comment.
unused method so removed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #61278 +/- ##
================================================
+ Coverage 73.1581% 75.3137% +2.1556%
================================================
Files 1726 1749 +23
Lines 478264 493956 +15692
================================================
+ Hits 349889 372017 +22128
+ Misses 106905 99067 -7838
- Partials 21470 22872 +1402
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
| return errors.Trace(err) | ||
| } | ||
| replacePitrIDMapSQL := "REPLACE INTO mysql.tidb_pitr_id_map (restored_ts, upstream_cluster_id, segment_id, id_map) VALUES (%?, %?, %?, %?);" | ||
| replacePitrIDMapSQL := "REPLACE INTO mysql.tidb_pitr_id_map (restore_id, restored_ts, upstream_cluster_id, segment_id, id_map) VALUES (%?, %?, %?, %?, %?);" |
There was a problem hiding this comment.
if new BR running on the old cluster without the column restore_id, maybe we need the compatibility.
There was a problem hiding this comment.
that's a good call, let me support that in the following PR, I want to make this PR as small as possible and just for updating the table schema.
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leavrth, yudongusa, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
Signed-off-by: Wenqi Mou <wenqimou@gmail.com>
doc pr is opened pingcap/docs#21040 |
|
/retest |
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@BornChanger: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This reverts commit cac7292. Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
This reverts commit 0a2cb7c. Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
5 participants
What problem does this PR solve?
Issue Number: close #61277
Problem Summary:
What changed and how does it work?
Adding a restore id column to the restore idmap table to allow multiples restore happens and not stepping on each other's toe
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.