Merge electron-builder pack and conda pack jobs#130
Merged
Conversation
- adapt ci commands accordingly - this should speed up, ci jobs as we no longer have to run `npm i` and `npm run pack` twice on ci - and for some reason this fixes(!) travis
4 tasks
Contributor
Author
|
Ping @jonmmease I wouldn't want to modify your conda recipes w/o you taking a 👁️ at it. |
Contributor
|
Sorry I missed this before! Will do by this evening |
jonmmease
reviewed
Sep 25, 2018
Contributor
jonmmease
left a comment
jonmmease
left a comment
There was a problem hiding this comment.
Looks great! Thanks for cleaning this up. Only single minor comment but otherwise 💃
| - run: | ||
| name: Conda pack | ||
| command: | | ||
| ./miniconda.sh -b -p $HOME/miniconda |
Contributor
There was a problem hiding this comment.
very minor, but this is the command that installs miniconda so it should probably be the last command in the "Install miniconda" block above.
I really like how much cleaner this is with the multi-line command: blocks!
Contributor
Author
|
Thanks for the review @jonmmease ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the conda pack recipe runs
npm iandnpm run packbefore packing. This has the advantage of making the conda-pack process standalone, but when one runs the electron-build pack and the conda pack jobs in succession (like we do on CI), these two steps are duplicated 🐢 .This PR makes the conda
recipe/folder assume thatnpm iandnpm run packhave been ran before the conda-pack command. This should significantly speed our Travis and AppVeyor CI runs. 🐎Moreover, for consistency, I merged the conda-pack steps with the electron-builder steps on CircleCI. Here, this makes our config file cleaner, but does add a few seconds of CI time. As the CircleCI workflow is almost always the first to complete, I think simplifying the config here is a win 🏆
Oh and this PR (for some reason) also makes Travis pass again. It has been falling all day long with
during the
npm run packcommand inside the conda recipe.@jonmmease does this look ok to you?