Skip to content

Add 'table' safeMode specs #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etpinard merged 2 commits into from
Aug 13, 2018
Merged

Add 'table' safeMode specs #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
593fb4f
add 'table' safeMode specs
etpinard Jun 26, 2018
2b5cf94
simplify estimateDataLength logic
etpinard Aug 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/component/plotly-graph/parse.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,23 @@ function findMaxArrayLength (cont) {
}

function estimateDataLength (trace) {
const topLevel = findMaxArrayLength(trace)
let dimLevel = 0
let cellLevel = 0

// special case for e.g. parcoords and splom traces
if (Array.isArray(trace.dimensions)) {
return trace.dimensions
dimLevel = trace.dimensions
.map(findMaxArrayLength)
.reduce((a, v) => a + v)
}

return findMaxArrayLength(trace)
// special case for e.g. table traces
if (isPlainObj(trace.cells)) {
cellLevel = findMaxArrayLength(trace.cells)
}

return Math.max(topLevel, dimLevel, cellLevel)
}

function maxPtsPerTrace (trace) {
Expand All @@ -169,6 +178,7 @@ function maxPtsPerTrace (trace) {
case 'scattergl':
case 'splom':
case 'pointcloud':
case 'table':
return 1e7

case 'scatterpolargl':
Expand Down
19 changes: 19 additions & 0 deletions test/unit/plotly-graph_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,25 @@ tap.test('parse:', t => {
})
})

t.test('failing table case', t => {
fn({
data: [{
type: 'table',
cells: {
values: [
new Array(5e6),
new Array(5e6),
new Array(5e6)
]
}
}]
}, {safeMode: true}, (errorCode, result) => {
t.equal(errorCode, 400, 'code')
t.type(result.msg, 'string', 'msg type')
t.end()
})
})

t.test('failing case from too many traces', t => {
var data = new Array(3e3)

Expand Down