Conversation
Contributor
|
Ok. I'll take it from here. Will be part of |
etpinard
reviewed
Jun 27, 2018
test/jasmine/tests/config_test.js
Outdated
| it('can be set to other base urls', function(done) { | ||
| Plotly.plot(gd, [], {}, {plotlyServerUrl: 'dummy'}) | ||
| .then(function() { | ||
| expect(gd._context.plotlyServerUrl).toBe('dummy'); |
Contributor
There was a problem hiding this comment.
These tests aren't great, but I couldn't find an easy way to mock the form submit in
Lines 214 to 245 in bcab36e
... to match topojsonURL config option
etpinard
reviewed
Jun 27, 2018
| beforeEach(function() { | ||
| gd = createGraphDiv(); | ||
| spyOn(HTMLFormElement.prototype, 'submit').and.callFake(function() { | ||
| form = this; |
| // base URL for the 'Edit in Chart Studio' (aka sendDataToCloud) mode bar button | ||
| // and the showLink/sendData on-graph link | ||
| plotlyServerUrl: 'https://plot.ly', | ||
| plotlyServerURL: 'https://plot.ly', |
Collaborator
There was a problem hiding this comment.
good call, that also seems more standard in the built-in API (eg canvas.toDataURL) though we have some other internal routines that use ...Url, like Drawing.setClipUrl.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2759 (comment)
I haven't tested this.