Conversation
... during post-publish step.
| '', | ||
| '// then', | ||
| 'Plotly.register(locale);', | ||
| 'Plotly.setPlotConfig({locale: \'fr\'})', |
Collaborator
|
@etpinard this looks great! Assuming you've verified that the built files work as described in the README (and they certainly look like they will) 💃 |
Contributor
Author
Verified ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3083, a continuation from #2670 (the partial-bundle-pkgs PR)
As locale files are fairly small, I decided to publish only one
plotly.js-localespackage (as opposed to one per locale) and ask users (in theplotly.js-localesREADME) to grab to relevant locale as:that is, users would npm-download all the locales, but only bundle the locale(s) they need.
Reviewers can look at:
publish-locales...publish-locales-build
to see to generated git-ignored files in
build/.cc @plotly/plotly_js and @nicolaskruchten who may find this useful for RCE and dash users.