Conversation
Collaborator
|
LGTM! Have you seen this fail on CI? ie just push a branch off this one with a purposely invalid addition to a mock, just to make sure it will properly flag failures for us. |
Contributor
Author
Good call. Tested locally and on the CI. |
Contributor
Author
alexcjohnson
approved these changes
May 12, 2021
Collaborator
alexcjohnson
left a comment
There was a problem hiding this comment.
Love it. Especially that we can switch from a whitelist to a blacklist (and hopefully over time cut that list down). 💃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup of #4762.
Addressing #4733.
Thanks to #5411, now we could
node.jsfor our mock validation 🎉It is now feasible to run validation tests both locally namely when contributors add new mocks/features to the library, as well as on CircleCI.
While new script does not depend on
browserifyandjasmineto resolve and load multiple files all at once, it is more robust now and could remove potential side effects of the previousmock_teston parallel runs.Plus after adding a new mock, it would automatically be tested by this system when there is no need to add its name to the list.
Since we used to run this in
noci_testright before publishing (and sometimes fail at final moments), the current setup should help reduce all the noise too.@plotly/plotly_js