Add missing package dependencies to resolve non-SPM linker failures#441
Open
scogeo wants to merge 2 commits intopointfreeco:mainfrom
Open
Add missing package dependencies to resolve non-SPM linker failures#441scogeo wants to merge 2 commits intopointfreeco:mainfrom
scogeo wants to merge 2 commits intopointfreeco:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes linker issues when non-SPM targets depend on
SqliteDataby explicitly declaring missing package dependencies.Details
When linking non-SPM targets to
SqliteData, builds can fail due to undeclared dependencies in thesqlite-datapackage:StructuredQueriesCoreis directly imported in multiple source files but is not listed in the package manifest.StructuredQueriesSQLiteCoreis not explicitly imported, but is resolved transitively by Swift Package Manager. However, this transitive resolution does not carry over to non-SPM targets, resulting in missing symbol linker errors (especially in test builds).A typical failing dependency chain:
In these cases:
Environment
Resolution
This PR explicitly adds the missing dependencies to the package manifest, ensuring consistent linking behavior across both SPM and non-SPM targets.