feat: add get_dataframe_report() method to Validate#341
feat: add get_dataframe_report() method to Validate#341rich-iannone merged 31 commits intoposit-dev:mainfrom
get_dataframe_report() method to Validate#341Conversation
|
NTS:
|
|
Hey @rich-iannone! I'm nearly done with adding #163 (still finishing up tests), but I'm blocked by ruff failures in CI. When my branch generates invalid-syntax: Unexpected indentation
--> pointblank\validate.pyi:165:1
|
163 | def get_dataframe(self, tbl_type: Literal['polars', 'pandas', 'duckdb'] = 'polars') -> Any: ...
164 | # === GENERATED START ===
165 | def col_sum_eq(
| ^^^^
invalid-syntax: Expected a statement
--> pointblank\validate.pyi:706:1
|
705 | # === GENERATED END ===Looks like the pointblank/scripts/generate_agg_validate_pyi.py Lines 112 to 144 in 40a773b I saw you may have done related work here not sure if there's anything I need to address on my branch or if I need to ignore? Either way will finish out the tests and mark it as "ready" when I finish those up. |
|
@Meghansaha first off, just want to say thank you for doing all this work! Been following it and it'll be a wonderful contribution to the package. The ruff/validate.pyi part is relatively new/complex and, if you're okay with it, I could take it from here to the finish line. My only additional change beyond that in this PR would be to change the name of the method from |
|
Hi @rich-iannone! No problem at all, I appreciate you letting me contribute. So sorry it took so long, life was "lifing" and I think as you're aware, duckdb is a pain on my Windows potato machine due to the permission error stuff. 😭 You can take over if you'd like as I'm sure you'll be faster than me. I did feel this needs more behavioral tests though like confirming correct column names and things like that. I think the rename makes sense too! |
get_dataframe method to Validateget_dataframe_report() method to Validate
Summary
Thank you for contributing to Pointblank! To make this process easier for everyone, please explain the context and purpose of your contribution. Also, list the changes made to the existing code or documentation.
Related GitHub Issues and PRs
Checklist