[2기-C] 정다현 SpringBoot Part1 Weekly Mission 제출합니다.#218
Merged
ksy90101 merged 14 commits intoprgrms-be-devcourse:mainfrom Apr 21, 2022
Merged
[2기-C] 정다현 SpringBoot Part1 Weekly Mission 제출합니다.#218ksy90101 merged 14 commits intoprgrms-be-devcourse:mainfrom
ksy90101 merged 14 commits intoprgrms-be-devcourse:mainfrom
Conversation
ksy90101
requested changes
Apr 16, 2022
build.gradle
Outdated
|
|
||
| group = 'org.prgrms' | ||
| version = '0.0.1-SNAPSHOT' | ||
| sourceCompatibility = '16' |
Comment on lines
+11
to
+21
| jar { | ||
| manifest { | ||
| attributes 'Main-Class': 'org.prgrms.springbootbasic.CommandLineApplication' | ||
| } | ||
| from { | ||
| configurations.runtimeClasspath.collect { | ||
| it.isDirectory() ? it : zipTree(it) | ||
| } | ||
| } | ||
| duplicatesStrategy = DuplicatesStrategy.EXCLUDE | ||
| } |
Member
Author
There was a problem hiding this comment.
gradle에서는 jar 파일을 생성하기 위해서 해당 코드가 필요해서 추가하였습니다.
Member
Author
There was a problem hiding this comment.
없어도 jar 파일이 만들어 지긴 하는데, 제가 의도한 대로 동작하지 않습니다. 제가 따로 콘솔용으로 클래스를 만들고 해당 클래스를 동작시키기 위해 해당 설정을 했습니다. 해당 설정을 통해서 어떤 main 클래스를 사용할 것이고, 그리고 의존하는 라이브러리도 같이 묶어주었습니다.
Comment on lines
+11
to
+14
| import java.util.UUID; | ||
|
|
||
|
|
||
| public class CommandLineApplication { |
There was a problem hiding this comment.
Suggested change
| import java.util.UUID; | |
| public class CommandLineApplication { | |
| import java.util.UUID; | |
| public class CommandLineApplication { |
| public static final String AVAILABLE_COMMANDS = "=== Voucher Program ===\nType exit to exit the program.\nType create to create a new voucher.\nType list to list all vouchers.\n"; | ||
| public static final String AVAILABLE_VOUCHERS = "Which type do you want, FixedAmountVoucher(Fixed) or PercentDiscountVoucher(Percent)?"; | ||
|
|
||
| public static void main(String[] args) { |
There was a problem hiding this comment.
여기에서는 단순히 애플리케이션을 실행하는 run메서드 하나만 넣어주세요.
지금 view와 로직이 엄청 섞여있네요.
view도 모두 다 분리해주세요.
Member
Author
There was a problem hiding this comment.
console 패키지를 따로 만들어서 뷰 관련한 코드를 넣었고 voucherService에는 로직이 실행되도록 하였습니다
| public Voucher getVoucher(UUID voucherId) { | ||
| return voucherRepository | ||
| .findById(voucherId) | ||
| .orElseThrow(() -> new RuntimeException(MessageFormat.format("Can not find a voucher for {0}", voucherId))); |
There was a problem hiding this comment.
과연 RuntimeException이 맞을까요?
좀 더 의미잇는 메서드를 사용해주세요.
Member
Author
There was a problem hiding this comment.
해당 메서드는 이번 과제에서 사용하는 메서드가 아니라서 삭제했습니다
| StringBuffer stringBuffer = new StringBuffer(); | ||
|
|
||
| for(UUID voucherId :storage.keySet()) { | ||
| stringBuffer.append(storage.get(voucherId).toString() + "\n"); |
| stringBuffer.append(storage.get(voucherId).toString() + "\n"); | ||
| } | ||
|
|
||
| return stringBuffer.toString(); |
There was a problem hiding this comment.
단순히 findAll은 string이 아니라, 자료구조인 List가 나와야 하지 않을까요?
|
|
||
| import java.util.UUID; | ||
|
|
||
| public class FixedAmountVoucher implements Voucher { |
|
|
||
| @Override | ||
| public long discount(long beforeDiscount) { | ||
| return beforeDiscount * (percent / 100); |
src/main/resources/logback.xml
Outdated
Comment on lines
+6
to
+7
| <!-- encoders are assigned the type | ||
| ch.qos.logback.classic.encoder.PatternLayoutEncoder by default --> |
|
2주차에서 다시 전체적으로 볼게요. 2단계 진행 해주세요 :) |
learn-programmers
added a commit
that referenced
this pull request
Apr 22, 2022
Revert main Branch #218
SpencerCP
added a commit
that referenced
this pull request
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 과제 설명
바우처 관리 애플리케이션 1주차 과제입니다.
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점