Skip to content

Hardcoded url#3941

Merged
raclim merged 3 commits intoprocessing:developfrom
Nishthajain7:hardcoded-url
Mar 10, 2026
Merged

Hardcoded url#3941
raclim merged 3 commits intoprocessing:developfrom
Nishthajain7:hardcoded-url

Conversation

@Nishthajain7
Copy link
Copy Markdown
Contributor

Issue:

Fixes #3910

Changes:

Use the EDITOR_URL environment variable to construct the callback URL. instead of hardcoded https://editor.p5js.org/auth/google/callback

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

Comment thread server/server.js
@Nishthajain7
Copy link
Copy Markdown
Contributor Author

Thank you for noticing. I checked out from the wrong branch

@Nishthajain7 Nishthajain7 requested a review from clairep94 March 7, 2026 13:53
@raclim raclim merged commit 138de19 into processing:develop Mar 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google OAuth callback URL hardcoded to production

5 participants