Skip to content

Remove migrated code#205

Merged
liamhuber merged 2 commits intomainfrom
remove-migrated-code
Mar 26, 2026
Merged

Remove migrated code#205
liamhuber merged 2 commits intomainfrom
remove-migrated-code

Conversation

@liamhuber
Copy link
Copy Markdown
Member

@liamhuber liamhuber commented Mar 24, 2026

Everything that was used downstream in semantikon is migrated into semantikon in pyiron/semantikon#410; for continuity, this PR thus depends on that one.

Closes #58
Closes #55

Flattening the project structure, adjusting the API paths accordingly, and adopting decision 5 are left to subsequent PRs.

Everything that was used downstream in semantikon is migrated into semantikon in pyiron/semantikon#410

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
@github-actions
Copy link
Copy Markdown

Binder 👈 Launch a binder notebook on branch pyiron/flowrep/remove-migrated-code

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.90%. Comparing base (6e9b2dc) to head (bbedbf9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   99.25%   99.90%   +0.64%     
==========================================
  Files          33       31       -2     
  Lines        2683     2007     -676     
==========================================
- Hits         2663     2005     -658     
+ Misses         20        2      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
@liamhuber liamhuber marked this pull request as ready for review March 26, 2026 14:00
@liamhuber liamhuber requested a review from samwaseda March 26, 2026 14:00
Copy link
Copy Markdown
Member

@samwaseda samwaseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there's not much to review :D

@liamhuber liamhuber merged commit 863a102 into main Mar 26, 2026
2 checks passed
@liamhuber liamhuber deleted the remove-migrated-code branch March 26, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undefined parameters inside workflow should throw an error when converted to workflow rep Replace _ and . by something unused

2 participants