Skip to content

Cover import_parser#224

Merged
liamhuber merged 5 commits intomainfrom
test-import-parser
Apr 10, 2026
Merged

Cover import_parser#224
liamhuber merged 5 commits intomainfrom
test-import-parser

Conversation

@liamhuber
Copy link
Copy Markdown
Member

@samwaseda, I was looking at coverage and noticed that parsers.import_parser is completely missing. I had Claude whip up some tests.

The module is not otherwise used anywhere else, and at fist I thought it was dead code. After quickly poking around, I see that parsers.import_parser.build_scope nicely digests the import attributes of parsers.dependency_parser.UndefinedVariableVisitor. Still, I'm not clear on what the intended utility is. The tests here functionally do the job of making sure it's all working, but they don't really illuminate to me how/why the tool should be used. Can you offer a suggestion for an application test?

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Binder 👈 Launch a binder notebook on branch pyiron/flowrep/test-import-parser

@liamhuber liamhuber requested a review from samwaseda April 8, 2026 14:37
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (bbcd200) to head (f09dcb8).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #224      +/-   ##
===========================================
+ Coverage   98.92%   100.00%   +1.07%     
===========================================
  Files          32        32              
  Lines        2227      2227              
===========================================
+ Hits         2203      2227      +24     
+ Misses         24         0      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Per @samwaseda's request

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
@liamhuber
Copy link
Copy Markdown
Member Author

What the heck. I moved the docstrings into the msg= field in the tests, and the bot went off its rocker and deleted all the content in the binder and docs envs 🤨

I'm going to roll back that commit and force-push and see if it repeats this bad behaviour.

@liamhuber liamhuber force-pushed the test-import-parser branch from 64f4825 to 7c9471e Compare April 10, 2026 01:32
@liamhuber
Copy link
Copy Markdown
Member Author

Well, I still don't know what nonsense the env update bot is getting up to, but the diff is once again just the one file I'm actually trying to change, so I'm going to live with it.

@liamhuber liamhuber merged commit 3765d81 into main Apr 10, 2026
22 checks passed
@liamhuber liamhuber deleted the test-import-parser branch April 10, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants