Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
===========================================
+ Coverage 98.92% 100.00% +1.07%
===========================================
Files 32 32
Lines 2227 2227
===========================================
+ Hits 2203 2227 +24
+ Misses 24 0 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samwaseda
approved these changes
Apr 8, 2026
Per @samwaseda's request Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
Member
Author
|
What the heck. I moved the docstrings into the I'm going to roll back that commit and force-push and see if it repeats this bad behaviour. |
64f4825 to
7c9471e
Compare
Member
Author
|
Well, I still don't know what nonsense the env update bot is getting up to, but the diff is once again just the one file I'm actually trying to change, so I'm going to live with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@samwaseda, I was looking at coverage and noticed that
parsers.import_parseris completely missing. I had Claude whip up some tests.The module is not otherwise used anywhere else, and at fist I thought it was dead code. After quickly poking around, I see that
parsers.import_parser.build_scopenicely digests the import attributes ofparsers.dependency_parser.UndefinedVariableVisitor. Still, I'm not clear on what the intended utility is. The tests here functionally do the job of making sure it's all working, but they don't really illuminate to me how/why the tool should be used. Can you offer a suggestion for an application test?