This repository was archived by the owner on Apr 7, 2026. It is now read-only.
fix: allow arbitrary env keys eg valueFrom#41
Open
lizthegrey wants to merge 3 commits intopyroscope-io:mainfrom
Open
fix: allow arbitrary env keys eg valueFrom#41lizthegrey wants to merge 3 commits intopyroscope-io:mainfrom
lizthegrey wants to merge 3 commits intopyroscope-io:mainfrom
Conversation
Author
|
Testing this against my own vendored copy, will report back... |
Contributor
|
Thank you for the contribution @lizthegrey! Yeah, I think we should keep the current behavior of Alternatively, since the main scenario for this is using secrets, we could use the {{- if .Values.envFromSecret }}
envFrom:
- secretRef:
name: {{ .Values.envFromSecret }}
{{- end }} |
petethepig
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.