Fixed libXau error in wheels for macOS 10.10#7764
Merged
radarhere merged 2 commits intopython-pillow:mainfrom Feb 3, 2024
Merged
Fixed libXau error in wheels for macOS 10.10#7764radarhere merged 2 commits intopython-pillow:mainfrom
radarhere merged 2 commits intopython-pillow:mainfrom
Conversation
hugovk
approved these changes
Jan 30, 2024
Member
hugovk
left a comment
There was a problem hiding this comment.
Thanks!
I'll note this adds an extra 10 minutes to the macOS x86_64 wheel job (36->46min) and macOS OS X 10.10 has been EOL for 6.5 years:
| cycle | codename | release | latest | latest release | eol | link |
|---|---|---|---|---|---|---|
| 14 | Sonoma | 2023-09-26 | 14.3 | 2024-01-22 | False | https://support.apple.com/HT213895 |
| 13 | Ventura | 2022-10-24 | 13.6.4 | 2024-01-22 | False | https://support.apple.com/HT213268 |
| 12 | Monterey | 2021-10-25 | 12.7.3 | 2024-01-22 | False | https://support.apple.com/HT212585 |
| 11 | Big Sur | 2020-11-12 | 11.7.10 | 2023-09-11 | 2023-09-26 | https://support.apple.com/HT211896 |
| 10.15 | Catalina | 2019-10-07 | 10.15.7 | 2020-09-24 | 2022-09-12 | https://support.apple.com/HT210642 |
| 10.14 | Mojave | 2018-09-24 | 10.14.6 | 2019-07-22 | 2021-10-25 | |
| 10.13 | High Sierra | 2017-09-25 | 10.13.6 | 2018-07-09 | 2020-12-01 | |
| 10.12 | Sierra | 2016-09-20 | 10.12.6 | 2017-07-19 | 2019-10-01 | |
| 10.11 | El Capitan | 2015-09-30 | 10.11.6 | 2016-07-18 | 2018-12-01 | |
| 10.10 | Yosemite | 2014-10-16 | 10.10.5 | 2015-08-13 | 2017-08-01 | |
| 10.9 | Mavericks | 2013-10-22 | 10.9.5 | 2014-09-17 | 2016-12-01 |
But the wheel builds are already very slow (1d 10h 21m total CPU time!) so another 10 minutes hardly makes a difference. And we may drop unofficial support for EOL OS versions in future releases with no notice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6862 (comment) is a report from a user that Pillow 10.2.0 wheels cause the following error on macOS 10.10
Investigating, I found that when generating wheels, GitHub Actions is outputting
This PR uninstalls brew's libxau, and starts building libxcb's dependencies on macOS x86-64 instead.
The user has confirmed that the wheels with these changes work on macOS 10.10.