Turn off nullability warnings for macOS SDK#7827
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Mar 11, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7759
The issue describes many warnings being raised when verbosely building Pillow on macOS. They are mostly warnings of "pointer is missing a nullability type specifier"
Investigating, I found https://gist.github.com/software-mariodiana/de55a56935730b08d7a5a2a05c44dcd3 stating "These warning are added so that Objective-C code will be compatible with Swift"
https://stackoverflow.com/questions/32539285/pointer-is-missing-a-nullability-type-specifier pointed me to https://developer.apple.com/swift/blog/?id=25 for some more detail about this compatibility.
So given that it is something that is acknowledged, the solution is just to turn off the warnings, with
-Wno-nullability-completeness.