Raise ValueError if seeking to greater than offset-sized integer in TIFF#7883
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Apr 1, 2024
Merged
Raise ValueError if seeking to greater than offset-sized integer in TIFF#7883hugovk merged 1 commit intopython-pillow:mainfrom
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7876
The issue provided an image that raises
ValueError: cannot fit 'int' into an offset-sized integerwhen seeking to a large offset in a TIFF image.This changes it to be
ValueError: Unable to seek to frameinstead.I'm not highly convinced of the need for this change, but it at least documents in our code that this may happen.
Also, if the image is instead a BytesIO instance,
Pillow currently raises
OverflowError: Python int too large to convert to C ssize_t. This would also become a ValueError with this PR.