Do not read layers immediately when opening PSD images#8039
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Jun 25, 2024
Merged
Do not read layers immediately when opening PSD images#8039hugovk merged 1 commit intopython-pillow:mainfrom
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
hugovk
approved these changes
Jun 25, 2024
Member
hugovk
left a comment
There was a problem hiding this comment.
👍
main:
❯ python -m timeit -s "from PIL import Image" "Image.open('Tests/images/hopper.psd')"
2000 loops, best of 5: 166 usec per loop
❯ python -m timeit -s "from PIL import Image" "im = Image.open('Tests/images/hopper.psd'); im.layers"
2000 loops, best of 5: 164 usec per loopPR:
❯ python -m timeit -s "from PIL import Image" "Image.open('Tests/images/hopper.psd')"
2000 loops, best of 5: 101 usec per loop
❯ python -m timeit -s "from PIL import Image" "im = Image.open('Tests/images/hopper.psd'); im.layers"
2000 loops, best of 5: 164 usec per loop(These runs were actually the third ones, to make sure everything had imported properly and avoid delays after an initial build.)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening a PSD image, this PR skips reading and parsing the PSD layers until the user calls
im.layers,im.n_framesorim.is_animated.This will improve performance, and also allow users who just want to
open()an image without seeking to workaround any errors that might be raised when parsing layers, such as in #8034