Added filename placeholder in winbuild URL#8498
Merged
radarhere merged 2 commits intopython-pillow:mainfrom Oct 26, 2024
Merged
Added filename placeholder in winbuild URL#8498radarhere merged 2 commits intopython-pillow:mainfrom
radarhere merged 2 commits intopython-pillow:mainfrom
Conversation
nulano
reviewed
Oct 25, 2024
winbuild/build_prepare.py
Outdated
| "libjpeg": { | ||
| "url": f"{SF_PROJECTS}/libjpeg-turbo/files/{V['JPEGTURBO']}/" | ||
| f"libjpeg-turbo-{V['JPEGTURBO']}.tar.gz/download", | ||
| "FILENAME/download", |
Contributor
There was a problem hiding this comment.
This string probably fits on a single line now.
Member
Author
There was a problem hiding this comment.
You're right. I've pushed a commit.
nulano
approved these changes
Oct 25, 2024
This was referenced Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several places in
winbuild/build_prepare.pywhere the "filename" is replicated in the "url"Pillow/winbuild/build_prepare.py
Lines 163 to 165 in 822ec3d
I wonder if
is neater, reducing duplication?
Feel free to reject if others think it isn't simpler.