Skip to content

GH-101696: invalidate type version tag in _PyStaticType_Dealloc #101697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 3 commits into from
Feb 8, 2023
Merged

GH-101696: invalidate type version tag in _PyStaticType_Dealloc #101697

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5dc0dd
invalidate cache counter
kumaraditya303 Feb 8, 2023
60b1ec0
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 8, 2023
c074ee1
Update Misc/NEWS.d/next/Core and Builtins/2023-02-08-17-13-31.gh-issu…
erlend-aasland Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2023-02-08-17-13-31.gh-issue-101696.seJhTt.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Invalidate type version tag in ``_PyStaticType_Dealloc`` for static types avoiding bug where a false cache hit could crash the interpreter. Patch by Kumar Aditya
Comment thread
erlend-aasland marked this conversation as resolved.
Outdated
2 changes: 2 additions & 0 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4469,6 +4469,8 @@ _PyStaticType_Dealloc(PyTypeObject *type)
}

type->tp_flags &= ~Py_TPFLAGS_READY;
type->tp_flags &= ~Py_TPFLAGS_VALID_VERSION_TAG;
type->tp_version_tag = 0;

if (type->tp_flags & _Py_TPFLAGS_STATIC_BUILTIN) {
_PyStaticType_ClearWeakRefs(type);
Expand Down