Skip to content

gh-110171: libregrtest always sets random.seed unless --no-use-randseed is provided #110172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 8 commits into from
Oct 4, 2023
Merged

gh-110171: libregrtest always sets random.seed unless --no-use-randseed is provided #110172

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9c6634d
gh-110171: `libregrtest` always sets `random.seed` unless `--no-use-r…
sobolevn Oct 1, 2023
1bef639
Address review
sobolevn Oct 1, 2023
bc512ac
Restore seed
sobolevn Oct 1, 2023
b193156
Address review
sobolevn Oct 1, 2023
0d53c05
Fix test
sobolevn Oct 1, 2023
9ba3edb
Update Lib/test/libregrtest/main.py
vstinner Oct 1, 2023
e5ebf70
Merge
sobolevn Oct 1, 2023
7b18378
Update NEWS
sobolevn Oct 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/libregrtest/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def __init__(self, ns: Namespace, _add_python_opts: bool = False):
self.random_seed: int = (
ns.random_seed
if ns.random_seed is not None
else random.randrange(100_000_000)
else random.Random().getrandbits(32)
Comment thread
vstinner marked this conversation as resolved.
Outdated
)
self.output_on_failure: bool = ns.verbose3
self.timeout: float | None = ns.timeout
Expand Down